Skip to content

[IMP] accouting/l10n_br: Adding NFC-e feature #12921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[IMP] accouting/l10n_br: Adding NFC-e feature #12921

wants to merge 1 commit into from
+172 −0

Conversation

sclo-odoo
Copy link

@sclo-odoo sclo-odoo commented Apr 17, 2025 •
edited
Loading

Adding the NFC-e configurations and workflows to the user guide.

Suggestion is to add the separately from the other flows, Like the "Vendor Bill" flow, just because it's specificity

Documentation: https://docs.google.com/document/d/1s-OvUfxL6AZL37JSu_4eS-ruy4FV8rmHcaAgfvzm1LY/edit?usp=sharing

Screenshots are at: https://drive.google.com/drive/folders/1sZVYNTqyTUzioo9m6nbzgjhpAUQhUqgR?usp=sharing

@robodoo
Copy link
Collaborator

robodoo commented Apr 17, 2025

Pull request status dashboard

@sclo-odoo sclo-odoo marked this pull request as ready for review April 17, 2025 12:45
@sclo-odoo
Copy link
Author

@vbe-odoo Here's the PR of NFC-e

@sclo-odoo
Copy link
Author

sclo-odoo commented Apr 22, 2025 •
edited
Loading

@samueljlieber Hello!
Here's the PR for NFC-e E-invoice flow. Ready for review

I'm running the guideline tests on this last build, but it still saying that there's an error on a file called Tyro.srt that I don't know about.

But my doc seems Ok to me. Let me know if I need to do any adjustments

cc @vbe-odoo

@samueljlieber samueljlieber force-pushed the sclo-odoo-l10n-br-nfc-e-feature branch from e6b2d53 to 064807c Compare April 23, 2025 13:44
@samueljlieber samueljlieber changed the base branch from 18.0 to master April 23, 2025 13:45
@samueljlieber samueljlieber changed the base branch from master to 18.0 April 23, 2025 13:45
samueljlieber
samueljlieber approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sclo-odoo! Thank you for your work on this PR!

I hope you don't mind, since there were a number of changes, I've made a commit (064807c) to address the following:

  • Modified RST syntax to match conventions and guidelines
  • Added additional context for instruction where it was needed
  • Only added images that were necessary/helpful

With these changes, this PR should be all set to move to final review. However, @sclo-odoo please let me know your thoughts on my changes and I can make any final adjustments before sending to final review! Thank you! :)

@sclo-odoo
Copy link
Author

@samueljlieber Hello!
I saw the adjustments, that's ok to me! It's already good!

You can go forward with it.

@sclo-odoo @samueljlieber
[IMP] accouting/l10n_br: Adding NFC-e feature
a510db2 
Adding the NFC-e configurations and workflows to the user guide.
@samueljlieber samueljlieber force-pushed the sclo-odoo-l10n-br-nfc-e-feature branch from 064807c to a510db2 Compare April 23, 2025 16:57
@samueljlieber
Copy link
Contributor

Squashed commits in a510db2

@C3POdoo C3POdoo requested a review from a team April 23, 2025 16:59
@afma-odoo
Copy link
Contributor

Hi @sclo-odoo @samueljlieber!

Thanks for the update on the Brazilian page!
We're currently testing a new template and guidelines for localization documentation pages.
Since this update on the Brazilian page is quite big, it might be a good opportunity to apply those principles and make some structural adjustments to the page.
If you'd like to update this, I can provide you with the new template and guidelines.
Alternatively, I'd be happy to make the changes myself. But please note that I'll be off starting next Tuesday through Friday.

Let me know what you prefer. Thank you ☺️

@samueljlieber
Copy link
Contributor

Hey @afma-odoo! Im excited to see the updated guidelines!

Im okay with you updaing this PR, but Im going to leave it up to @sclo-odoo to make the decision :)

@vbe-odoo
Copy link
Contributor

vbe-odoo commented Apr 25, 2025 •
edited
Loading

Hello @afma-odoo, thanks for the heads up!
Please, help us with the adaptations for this PR, and if you have the new "template and guidelines for localization documentation pages" please share them with us for future reference.

Moreover, we will use what you do here to have a real example besides the new guidelines.

Thanks!
cc' @sclo-odoo

@sclo-odoo
Copy link
Author

Thank you @afma-odoo @vbe-odoo @samueljlieber
I think AFMA can apply the final changes and we're gonna see and learn about the new guidelines for the next ones.
💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueljlieber samueljlieber samueljlieber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sclo-odoo @robodoo @samueljlieber @afma-odoo @vbe-odoo